]> git.ipfire.org Git - thirdparty/gcc.git/commitdiff
gimple-lim: Reuse boolean var when moving PHI
authorAndrew Pinski <quic_apinski@quicinc.com>
Sat, 30 Nov 2024 21:12:13 +0000 (13:12 -0800)
committerAndrew Pinski <quic_apinski@quicinc.com>
Sun, 1 Dec 2024 07:34:31 +0000 (23:34 -0800)
While looking into PR 117859, I noticed that LIM
sometimes would produce `bool_var2 = bool_var1 != 0` instead
of just using bool_var2. This patch allows LIM to reuse bool_var1
in the place where bool_var2 was going to be used.

Bootstrapped and tested on x86_64-linux-gnu.

gcc/ChangeLog:

* tree-ssa-loop-im.cc (move_computations_worker): While moving
phi, reuse the lhs of the conditional if it is a boolean type.

Signed-off-by: Andrew Pinski <quic_apinski@quicinc.com>
gcc/tree-ssa-loop-im.cc

index 538a0588d332ee13338507a12a1913618b82f11c..0130a809e30f121859b553790adb1a28481dee40 100644 (file)
@@ -1304,11 +1304,22 @@ move_computations_worker (basic_block bb)
             edges of COND.  */
          extract_true_false_args_from_phi (dom, stmt, &arg0, &arg1);
          gcc_assert (arg0 && arg1);
-         t = make_ssa_name (boolean_type_node);
-         new_stmt = gimple_build_assign (t, gimple_cond_code (cond),
-                                         gimple_cond_lhs (cond),
-                                         gimple_cond_rhs (cond));
-         gsi_insert_on_edge (loop_preheader_edge (level), new_stmt);
+         /* For `bool_val != 0`, reuse bool_val. */
+         if (gimple_cond_code (cond) == NE_EXPR
+             && integer_zerop (gimple_cond_rhs (cond))
+             && types_compatible_p (TREE_TYPE (gimple_cond_lhs (cond)),
+                                    boolean_type_node))
+           {
+             t = gimple_cond_lhs (cond);
+           }
+         else
+           {
+             t = make_ssa_name (boolean_type_node);
+             new_stmt = gimple_build_assign (t, gimple_cond_code (cond),
+                                             gimple_cond_lhs (cond),
+                                             gimple_cond_rhs (cond));
+             gsi_insert_on_edge (loop_preheader_edge (level), new_stmt);
+           }
          new_stmt = gimple_build_assign (gimple_phi_result (stmt),
                                          COND_EXPR, t, arg0, arg1);
          todo |= TODO_cleanup_cfg;