]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
media: i2c: ds90ub960: Fix missing return check on ub960_rxport_read call
authorColin Ian King <colin.i.king@gmail.com>
Wed, 2 Oct 2024 16:53:29 +0000 (17:53 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Wed, 16 Oct 2024 07:32:41 +0000 (09:32 +0200)
The function ub960_rxport_read is being called and afterwards ret is
being checked for any failures, however ret is not being assigned to
the return of the function call. Fix this by assigning ret to the
return of the call which appears to be missing.

Fixes: afe267f2d368 ("media: i2c: add DS90UB960 driver")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Reviewed-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/i2c/ds90ub960.c

index ffe5f25f8647624be005da33a6412da2493413b4..58424d8f72af0323eae59ae6b6f1d757f8b9451c 100644 (file)
@@ -1286,7 +1286,7 @@ static int ub960_rxport_get_strobe_pos(struct ub960_data *priv,
 
        clk_delay += v & UB960_IR_RX_ANA_STROBE_SET_CLK_DELAY_MASK;
 
-       ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
+       ret = ub960_rxport_read(priv, nport, UB960_RR_SFILTER_STS_1, &v);
        if (ret)
                return ret;