]> git.ipfire.org Git - thirdparty/dhcpcd.git/commitdiff
Fix a coverity warning.
authorRoy Marples <roy@marples.name>
Tue, 2 Dec 2014 09:25:14 +0000 (09:25 +0000)
committerRoy Marples <roy@marples.name>
Tue, 2 Dec 2014 09:25:14 +0000 (09:25 +0000)
dhcpcd.c

index 5293f9713cbef753656b9581414d2cd3f2a36913..9e35738f554530f202756eab38d4c9c97cc64d8d 100644 (file)
--- a/dhcpcd.c
+++ b/dhcpcd.c
@@ -449,12 +449,13 @@ configure_interface1(struct interface *ifp)
                            sizeof(ifo->iaid));
                else {
                        uint32_t len;
-                       
+
                        len = (uint32_t)strlen(ifp->name);
                        if (len <= sizeof(ifo->iaid)) {
                                memcpy(ifo->iaid, ifp->name, len);
-                               memset(ifo->iaid + len, 0,
-                                   sizeof(ifo->iaid) - len);
+                               if (len < sizeof(ifo->iaid))
+                                       memset(ifo->iaid + len, 0,
+                                           sizeof(ifo->iaid) - len);
                        } else {
                                /* IAID is the same size as a uint32_t */
                                len = htonl(ifp->index);