]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
dsdb:mod:operational: initialise a pointer (CID 1499411)
authorDouglas Bagnall <douglas.bagnall@catalyst.net.nz>
Wed, 31 Jul 2024 01:27:40 +0000 (13:27 +1200)
committerDouglas Bagnall <dbagnall@samba.org>
Wed, 28 Aug 2024 04:24:39 +0000 (04:24 +0000)
A Coverity false positive (we check for error) but it is worth
doing per README.Coding

Signed-off-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Reviewed-by: Jennifer Sutton <josutton@catalyst.net.nz>
source4/dsdb/samdb/ldb_modules/operational.c

index d911118417891a93b371076728e75fd69bb03c85..b86449b3b3b9bdde150853fe399fbfbb7157afa7 100644 (file)
@@ -557,7 +557,7 @@ static int construct_msds_isrodc_with_server_dn(struct ldb_module *module,
                                                struct ldb_dn *dn,
                                                struct ldb_request *parent)
 {
-       struct ldb_dn *server_dn;
+       struct ldb_dn *server_dn = NULL;
        const char *attr_obj_cat[] = { "objectCategory", NULL };
        struct ldb_result *res;
        struct ldb_message_element *object_category;
@@ -594,7 +594,7 @@ static int construct_msds_isrodc_with_computer_dn(struct ldb_module *module,
                                                  struct ldb_request *parent)
 {
        int ret;
-       struct ldb_dn *server_dn;
+       struct ldb_dn *server_dn = NULL;
 
        ret = dsdb_module_reference_dn(module, msg, msg->dn, "serverReferenceBL",
                                       &server_dn, parent);