]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mm/damon/tests/core-kunit: handle alloc failures on damon_test_split_at()
authorSeongJae Park <sj@kernel.org>
Sat, 1 Nov 2025 18:19:59 +0000 (11:19 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 8 Jan 2026 09:14:47 +0000 (10:14 +0100)
commit 5e80d73f22043c59c8ad36452a3253937ed77955 upstream.

damon_test_split_at() is assuming all dynamic memory allocation in it will
succeed.  Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail.  In
the case, inappropriate memory access can happen.  Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-6-sj@kernel.org
Fixes: 17ccae8bb5c9 ("mm/damon: add kunit tests")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [5.15+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
mm/damon/tests/core-kunit.h

index cf22e09a3507f0b2ad7e2d2d37adb16829a273a7..43d532b7b60a2aa8f077177532801c6f6ecdbd93 100644 (file)
@@ -124,8 +124,19 @@ static void damon_test_split_at(struct kunit *test)
        struct damon_target *t;
        struct damon_region *r, *r_new;
 
+       if (!c)
+               kunit_skip(test, "ctx alloc fail");
        t = damon_new_target();
+       if (!t) {
+               damon_destroy_ctx(c);
+               kunit_skip(test, "target alloc fail");
+       }
        r = damon_new_region(0, 100);
+       if (!r) {
+               damon_destroy_ctx(c);
+               damon_free_target(t);
+               kunit_skip(test, "region alloc fail");
+       }
        r->nr_accesses_bp = 420000;
        r->nr_accesses = 42;
        r->last_nr_accesses = 15;