Use int for getopt() results

On ppc, char is unsigned and getopt()/getopt_long() returning -1 (= end of
arguments) is translated to 255 and results in 'Invalid command line option'.

Signed-off-by: Jan Safranek <jsafrane@redhat.com>
Signed-off-by: Dhaval Giani <dhaval.giani@gmail.com>

diff --git a/src/tools/cgcreate.c b/src/tools/cgcreate.c
index 616fa163f0970efc9929ca8c7d6e542fc377bd39..435df4a02b5c9791218945cfa9710bddf4937a2c 100644 (file)
--- a/src/tools/cgcreate.c
+++ b/src/tools/cgcreate.c
@@ -31,7 +31,7 @@ int main(int argc, char *argv[])
 {
        int ret = 0;
        int i, j;
-       char c;
+       int c;
 
        /* Structure to get GID from group name */
        struct group *grp = NULL;

diff --git a/src/tools/cgdelete.c b/src/tools/cgdelete.c
index af1cb7e633a14227a7302f374e20d1a97f275068..7da6ab40bc1879e98d1150162502bfd3a4ace895 100644 (file)
--- a/src/tools/cgdelete.c
+++ b/src/tools/cgdelete.c
@@ -28,7 +28,7 @@ int main(int argc, char *argv[])
 {
        int ret = 0;
        int i, j;
-       char c;
+       int c;
        int flags = 0;
        int final_ret = 0;
        int capacity = 0;

diff --git a/src/tools/cgexec.c b/src/tools/cgexec.c
index 6fec85a7bcf2bd3900da0e1a2ff42578c78e8339..07af199061b50ac7ae273a351990101b49b71f5d 100644 (file)
--- a/src/tools/cgexec.c
+++ b/src/tools/cgexec.c
@@ -43,7 +43,7 @@ int main(int argc, char *argv[])
        uid_t uid;
        gid_t gid;
        pid_t pid;
-       char c;
+       int c;
        struct cgroup_group_spec *cgroup_list[CG_HIER_MAX];
 
        if (argc < 2) {