]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc: qcom: llcc: fix v1 SB syndrome register offset
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 30 Mar 2026 09:51:11 +0000 (02:51 -0700)
committerBjorn Andersson <andersson@kernel.org>
Mon, 30 Mar 2026 13:23:36 +0000 (08:23 -0500)
The llcc_v1_edac_reg_offset table uses 0x2304c for trp_ecc_sb_err_syn0,
which is inconsistent with the surrounding TRP ECC registers (0x2034x)
and with llcc_v2_1_edac_reg_offset, where trp_ecc_sb_err_syn0 is 0x2034c
adjacent to trp_ecc_error_status0/1 at 0x20344/0x20348.

Use 0x2034c for llcc v1 so the SB syndrome register follows the expected
+0x4 progression from trp_ecc_error_status1. This fixes EDAC reading the
wrong register for SB syndrome reporting.

Fixes: c13d7d261e36 ("soc: qcom: llcc: Pass LLCC version based register offsets to EDAC driver")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20260330095118.2657362-1-alok.a.tiwari@oracle.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
drivers/soc/qcom/llcc-qcom.c

index 68a3416692e0a8eb892efdce501b8b555ebe4010..0161ceec884210e84760a1df5728a53fc5aec316 100644 (file)
@@ -4030,7 +4030,7 @@ static const struct llcc_slice_config x1e80100_data[] = {
 static const struct llcc_edac_reg_offset llcc_v1_edac_reg_offset = {
        .trp_ecc_error_status0 = 0x20344,
        .trp_ecc_error_status1 = 0x20348,
-       .trp_ecc_sb_err_syn0 = 0x2304c,
+       .trp_ecc_sb_err_syn0 = 0x2034c,
        .trp_ecc_db_err_syn0 = 0x20370,
        .trp_ecc_error_cntr_clear = 0x20440,
        .trp_interrupt_0_status = 0x20480,