common: Use signed return value for ieee802_11_defrag_mle_subelem

The function returns -1 on error which is not a valid value for size_t.
Fix this by returning ssize_t.

Fixes: 88f7d4cedfea ("Helper function for defragmenting of Multi-Link element subelements")
CC: Pooventhiran G <quic_pooventh@quicinc.com>
Signed-off-by: Benjamin Berg <benjamin.berg@intel.com>

diff --git a/src/common/ieee802_11_common.c b/src/common/ieee802_11_common.c
index 320d586fc8a08f5028bd681376b99ab2c1fcc922..5d1e02f81e1ec53ec58f2b3221ef98fe52f27397 100644 (file)
--- a/src/common/ieee802_11_common.c
+++ b/src/common/ieee802_11_common.c
@@ -3486,9 +3486,9 @@ struct wpabuf * ieee802_11_defrag(const u8 *data, size_t len, bool ext_elem)
  * of data, see IEEE Std 802.11be-2024, Figure 35-4 - Per-STA Profile subelement
  * fragmentation within a fragmented Multi-Link element.
  */
-size_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf,
-                                    const u8 *parent_subelem,
-                                    size_t *defrag_len)
+ssize_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf,
+                                     const u8 *parent_subelem,
+                                     size_t *defrag_len)
 {
        u8 *buf, *pos, *end;
        size_t len, subelem_len;

diff --git a/src/common/ieee802_11_common.h b/src/common/ieee802_11_common.h
index 6a108ccf7ee5475d40913e93b6e61e58e186753d..09bd0675a1b2593c6ca31b42d51973e0317e2812 100644 (file)
--- a/src/common/ieee802_11_common.h
+++ b/src/common/ieee802_11_common.h
@@ -382,9 +382,9 @@ int ieee802_edmg_is_allowed(struct ieee80211_edmg_config allowed,
                            struct ieee80211_edmg_config requested);
 
 struct wpabuf * ieee802_11_defrag(const u8 *data, size_t len, bool ext_elem);
-size_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf,
-                                    const u8 *parent_subelem,
-                                    size_t *defrag_len);
+ssize_t ieee802_11_defrag_mle_subelem(struct wpabuf *mlbuf,
+                                     const u8 *parent_subelem,
+                                     size_t *defrag_len);
 const u8 * get_ml_ie(const u8 *ies, size_t len, u8 type);
 const u8 * get_basic_mle_mld_addr(const u8 *buf, size_t len);
 const u8 * get_basic_mle_eml_capa(const u8 *buf, size_t len);