Define ap_method_mask_t (typedef for apr_uint64_t) and use for method

bitmasks rather than apr_int64_t.  Fixes UBSan errors shifting to the
top bit of a signed integer.

* include/httpd.h: Add ap_method_mask_t, use it for AP_METHOD_BIT.
  (struct ap_method_mask_t): Likewise for method_mask field.
  (struct request_rec): Likewise for allowed field.

* include/http_config.h (struct cmd_parms): Likewise for limited field.

* include/ap_mmn.h: Bump MMN major.

* modules/*/*.c: Adjust all method masks to use ap_method_mask_t.

git-svn-id: https://svn.apache.org/repos/asf/httpd/httpd/trunk@1874114 13f79535-47bb-0310-9956-ffa450edef68

diff --git a/CHANGES b/CHANGES
index 450d87776a22af059391724d69825e05e91ba88c..d127c598b8019ae0f49ebfc68233b58a70b3f52e 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -1,6 +1,11 @@
                                                          -*- coding: utf-8 -*-
 Changes with Apache 2.5.1
 
+  *) core: ap_method_mask_t type added for method bitmasks, changed
+     from apr_int64_t and used for the method_mask field in
+     ap_method_list_t, AP_METHOD_BIT, allowed field of request_rec,
+     limited field of cmd_parms.  [Joe Orton]
+
   *) mod_ssl: Do not keep connections to OCSP responders alive when doing
      OCSP requests.  PR 64135.  [Ruediger Pluem]
 

diff --git a/include/ap_mmn.h b/include/ap_mmn.h
index b48d29dc9be05cea33c5a14fe8be7cf2566bdb29..664ae7e251c036961da25fc08fe7a12a0d43a351 100644 (file)
--- a/include/ap_mmn.h
+++ b/include/ap_mmn.h
@@ -621,14 +621,15 @@
  * 20190312.7 (2.5.1-dev)  AP_REG_DEFAULT macro in ap_regex.h
  * 20190312.8 (2.5.1-dev)  ap_is_chunked() in httpd.h
  * 20190312.9 (2.5.1-dev)  AP_REG_NO_DEFAULT macro in ap_regex.h
+ * 20200217.0 (2.5.1-dev)  Add and use ap_method_mask_t type
  */
 
 #define MODULE_MAGIC_COOKIE 0x41503235UL /* "AP25" */
 
 #ifndef MODULE_MAGIC_NUMBER_MAJOR
-#define MODULE_MAGIC_NUMBER_MAJOR 20190312
+#define MODULE_MAGIC_NUMBER_MAJOR 20200217
 #endif
-#define MODULE_MAGIC_NUMBER_MINOR 9            /* 0...n */
+#define MODULE_MAGIC_NUMBER_MINOR 0            /* 0...n */
 
 /**
  * Determine if the server's current MODULE_MAGIC_NUMBER is at least a

diff --git a/include/http_config.h b/include/http_config.h
index ce1a51e1b3ff9e2e8eed6763e22edbe67f7389cb..2aac6d4325398fe4df55275290953e429ef3c4e3 100644 (file)
--- a/include/http_config.h
+++ b/include/http_config.h
@@ -295,7 +295,7 @@ struct cmd_parms_struct {
     /** Table of directives allowed per AllowOverrideList */
     apr_table_t *override_list;
     /** Which methods are <Limit>ed */
-    apr_int64_t limited;
+    ap_method_mask_t limited;
     /** methods which are limited */
     apr_array_header_t *limited_xmethods;
     /** methods which are xlimited */

diff --git a/include/httpd.h b/include/httpd.h
index 0fa5341f603fced1b6c36182165f64815801db16..88c71c0c2238ead69186c1f864c05dda505a228d 100644 (file)
--- a/include/httpd.h
+++ b/include/httpd.h
@@ -637,10 +637,14 @@ AP_DECLARE(const char *) ap_get_server_built(void);
  */
 #define METHODS     64
 
+/**
+ * The type used for method masks.
+ */
+typedef apr_uint64_t ap_method_mask_t;
 /**
  * The method mask bit to shift for anding with a bitmask.
  */
-#define AP_METHOD_BIT ((apr_int64_t)1)
+#define AP_METHOD_BIT ((ap_method_mask_t)1)
 /** @} */
 
 
@@ -656,7 +660,7 @@ typedef struct ap_method_list_t ap_method_list_t;
  */
 struct ap_method_list_t {
     /** The bitmask used for known methods */
-    apr_int64_t method_mask;
+    ap_method_mask_t method_mask;
     /** the array used for extension methods */
     apr_array_header_t *method_list;
 };
@@ -886,7 +890,7 @@ struct request_rec {
      *  HTTP_METHOD_NOT_ALLOWED.  Unfortunately this means that a Script GET
      *  handler can't be installed by mod_actions.
      */
-    apr_int64_t allowed;
+    ap_method_mask_t allowed;
     /** Array of extension methods */
     apr_array_header_t *allowed_xmethods;
     /** List of allowed methods */

diff --git a/modules/aaa/mod_access_compat.c b/modules/aaa/mod_access_compat.c
index e9f1abe4835b03d1d90bb5e75f24d58fec4d5990..866e208ff39fee2a284a836cb94b7163b460f4c9 100644 (file)
--- a/modules/aaa/mod_access_compat.c
+++ b/modules/aaa/mod_access_compat.c
@@ -53,7 +53,7 @@ enum allowdeny_type {
 };
 
 typedef struct {
-    apr_int64_t limited;
+    ap_method_mask_t limited;
     union {
         char *from;
         apr_ipsubnet_t *ip;
@@ -243,7 +243,7 @@ static int find_allowdeny(request_rec *r, apr_array_header_t *a, int method)
 {
 
     allowdeny *ap = (allowdeny *) a->elts;
-    apr_int64_t mmask = (AP_METHOD_BIT << method);
+    ap_method_mask_t mmask = (AP_METHOD_BIT << method);
     int i;
     int gothost = 0;
     const char *remotehost = NULL;

diff --git a/modules/aaa/mod_allowmethods.c b/modules/aaa/mod_allowmethods.c
index dd411969e0036132a97a4647da83ee1354818b74..3062efd323f7e3e48e949ffef9815b97e89b2354 100644 (file)
--- a/modules/aaa/mod_allowmethods.c
+++ b/modules/aaa/mod_allowmethods.c
@@ -45,7 +45,7 @@
 
 typedef struct am_conf_t {
     int allowed_set;
-    apr_int64_t allowed;
+    ap_method_mask_t allowed;
 } am_conf_t;
 
 module AP_MODULE_DECLARE_DATA allowmethods_module;

diff --git a/modules/aaa/mod_authz_core.c b/modules/aaa/mod_authz_core.c
index 40e5fe1414abf449a4d9190d08df5e677eb52fa1..53c2663917f664dfabfd9e8da5f7c853cb3f2c1c 100644 (file)
--- a/modules/aaa/mod_authz_core.c
+++ b/modules/aaa/mod_authz_core.c
@@ -70,7 +70,7 @@ struct authz_section_conf {
     const char *provider_args;
     const void *provider_parsed_args;
     const authz_provider *provider;
-    apr_int64_t limited;
+    ap_method_mask_t limited;
     authz_logic_op op;
     int negate;
     /** true if this is not a real container but produced by AuthMerging;
@@ -478,7 +478,7 @@ static const char *add_authz_section(cmd_parms *cmd, void *mconfig,
     authz_section_conf *old_section = conf->section;
     authz_section_conf *section;
     int old_overrides = cmd->override;
-    apr_int64_t old_limited = cmd->limited;
+    ap_method_mask_t old_limited = cmd->limited;
     const char *errmsg;
 
     if (endp == NULL) {
@@ -1016,7 +1016,7 @@ static authz_status method_check_authorization(request_rec *r,
                                                const char *require_line,
                                                const void *parsed_require_line)
 {
-    const apr_int64_t *allowed = parsed_require_line;
+    const ap_method_mask_t *allowed = parsed_require_line;
     if (*allowed & (AP_METHOD_BIT << r->method_number))
         return AUTHZ_GRANTED;
     else
@@ -1027,7 +1027,7 @@ static const char *method_parse_config(cmd_parms *cmd, const char *require_line,
                                        const void **parsed_require_line)
 {
     const char *w, *t;
-    apr_int64_t *allowed = apr_pcalloc(cmd->pool, sizeof(apr_int64_t));
+    ap_method_mask_t *allowed = apr_pcalloc(cmd->pool, sizeof *allowed);
 
     t = require_line;
 

diff --git a/modules/http/http_protocol.c b/modules/http/http_protocol.c
index 205b6bdf8a81f3da377c96f78c9de2f422726c51..33c9d083ef7f53db6a8c9616fbe40e4e801b6b8d 100644 (file)
--- a/modules/http/http_protocol.c
+++ b/modules/http/http_protocol.c
@@ -854,7 +854,7 @@ AP_DECLARE(const char *) ap_get_status_line(int status)
  */
 static char *make_allow(request_rec *r)
 {
-    apr_int64_t mask;
+    ap_method_mask_t mask;
     apr_array_header_t *allow = apr_array_make(r->pool, 10, sizeof(char *));
     apr_hash_index_t *hi = apr_hash_first(r->pool, methods_registry);
     /* For TRACE below */

diff --git a/modules/http/http_request.c b/modules/http/http_request.c
index 8f27e0f5f597bbb26f7869f66e87d7aeb5801756..15c1fd5124308d1ef9db7daa50067fcad900d7e4 100644 (file)
--- a/modules/http/http_request.c
+++ b/modules/http/http_request.c
@@ -857,7 +857,7 @@ AP_DECLARE(void) ap_allow_standard_methods(request_rec *r, int reset, ...)
 {
     int method;
     va_list methods;
-    apr_int64_t mask;
+    ap_method_mask_t mask;
 
     /*
      * Get rid of any current settings if requested; not just the