]> git.ipfire.org Git - thirdparty/tornado.git/commitdiff
Fix a potential leak of an unclosed AsyncHTTPClient.
authorBen Darnell <ben@bendarnell.com>
Thu, 24 Jul 2014 02:18:27 +0000 (22:18 -0400)
committerBen Darnell <ben@bendarnell.com>
Thu, 24 Jul 2014 02:18:27 +0000 (22:18 -0400)
tornado/test/httpclient_test.py

index 124239992265fab21f0115c5ed000b362fd5d137..225911087d428fce1a9d79f1a90a35b89ab7f0e2 100644 (file)
@@ -324,10 +324,12 @@ Transfer-Encoding: chunked
         # Construct a new instance of the configured client class
         client = self.http_client.__class__(self.io_loop, force_instance=True,
                                             defaults=defaults)
-        client.fetch(self.get_url('/user_agent'), callback=self.stop)
-        response = self.wait()
-        self.assertEqual(response.body, b'TestDefaultUserAgent')
-        client.close()
+        try:
+            client.fetch(self.get_url('/user_agent'), callback=self.stop)
+            response = self.wait()
+            self.assertEqual(response.body, b'TestDefaultUserAgent')
+        finally:
+            client.close()
 
     def test_304_with_content_length(self):
         # According to the spec 304 responses SHOULD NOT include