]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: aio_aio12_8: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:29 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:36 +0000 (15:49 +0200)
The "aio_aio12_8" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a supported
board (AIO12-8, AI12-8, or AO12-4).  It currently allows any base
address to be configured but the hardware only supports base addresses
(set by on-board jumpers) in the range 0x100 to 0x3C0 on 32-byte
boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-5-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/aio_aio12_8.c

index 227a86a3a7605b0106e9375a3e464bb623a080dd..1d9e14981928f4ea86ae50d4f48a0e36d0eb360a 100644 (file)
@@ -202,7 +202,8 @@ static int aio_aio12_8_attach(struct comedi_device *dev,
        struct comedi_subdevice *s;
        int ret;
 
-       ret = comedi_request_region(dev, it->options[0], 32);
+       ret = comedi_check_request_region(dev, it->options[0], 32,
+                                         0x100, 0x3ff, 32);
        if (ret)
                return ret;