]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
comedi: ni_labpc: Add sanity checks for I/O base address
authorIan Abbott <abbotti@mev.co.uk>
Fri, 30 Jan 2026 16:47:56 +0000 (16:47 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Apr 2026 13:49:39 +0000 (15:49 +0200)
The "ni_labpc" driver uses an admin-supplied configuration option
(`it->options[0]`) to configure the I/O port base address of a
Lab-PC-1200 series or Lab-PC+ board.  It currently allows any base
address to be configured but the hardware only supports base addresses
(configured by a configuration utility and stored in nonvolatile memory)
in the range 0 to 0x3E0 on 32-byte boundaries.

Add a sanity check to ensure the device is not configured at an
unsupported base address.

Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://patch.msgid.link/20260130170416.49994-32-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/comedi/drivers/ni_labpc.c

index b25a8e117072cc7db02486868dc311943648945b..93b5333a99b5da51024b29ee06abf14fea2fcc99 100644 (file)
@@ -78,7 +78,8 @@ static int labpc_attach(struct comedi_device *dev, struct comedi_devconfig *it)
        unsigned int dma_chan = it->options[2];
        int ret;
 
-       ret = comedi_request_region(dev, it->options[0], 0x20);
+       ret = comedi_check_request_region(dev, it->options[0], 0x20,
+                                         0, 0x3ff, 32);
        if (ret)
                return ret;