]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
usb: phy: generic: Use proper helper for property detection
authorAlexander Stein <alexander.stein@ew.tq-group.com>
Mon, 20 Jan 2025 14:42:51 +0000 (15:42 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 Mar 2025 19:54:16 +0000 (12:54 -0700)
[ Upstream commit 309005e448c1f3e4b81e4416406991b7c3339c1d ]

Since commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is
used on non-boolean properties") a warning is raised if this function
is used for property detection. of_property_present() is the correct
helper for this.

Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20250120144251.580981-1-alexander.stein@ew.tq-group.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/usb/phy/phy-generic.c

index e7d50e0a1612389a427e0cbaefcae3c1bbea8458..aadf98f65c6084d17cb0173367e2ec5d262778ef 100644 (file)
@@ -212,7 +212,7 @@ int usb_phy_gen_create_phy(struct device *dev, struct usb_phy_generic *nop)
                if (of_property_read_u32(node, "clock-frequency", &clk_rate))
                        clk_rate = 0;
 
-               needs_clk = of_property_read_bool(node, "clocks");
+               needs_clk = of_property_present(node, "clocks");
        }
        nop->gpiod_reset = devm_gpiod_get_optional(dev, "reset",
                                                   GPIOD_ASIS);