]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
mmc: loongson2: prevent integer overflow in ret variable
authorSergio Perez Gonzalez <sperezglz@gmail.com>
Mon, 7 Jul 2025 18:55:41 +0000 (12:55 -0600)
committerUlf Hansson <ulf.hansson@linaro.org>
Thu, 10 Jul 2025 08:43:38 +0000 (10:43 +0200)
In loongson2_mmc_dll_mode_init(), `ret` variable is declared
as u32 but it is expected to hold an int value.

Fixes: d0f8e961deae ("mmc: loongson2: Add Loongson-2K2000 SD/SDIO/eMMC controller driver")
Reported-by: https://scan7.scan.coverity.com/#/project-view/53936/11354?selectedIssue=1644958
Signed-off-by: Sergio Perez Gonzalez <sperezglz@gmail.com>
Reviewed-by: Binbin Zhou <zhoubinbin@loongson.cn>
Link: https://lore.kernel.org/r/20250707185545.46275-1-sperezglz@gmail.com
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/mmc/host/loongson2-mmc.c

index 515ccf834f0ab0be75cb24ef81583f35af18d91f..ba6bb8fd5535db85f427025eea785a44db977d89 100644 (file)
@@ -485,7 +485,8 @@ close_transfer:
 
 static void loongson2_mmc_dll_mode_init(struct loongson2_mmc_host *host)
 {
-       u32 val, pad_delay, delay, ret;
+       u32 val, pad_delay, delay;
+       int ret;
 
        regmap_update_bits(host->regmap, LOONGSON2_MMC_REG_SEL,
                           LOONGSON2_MMC_SEL_DATA, LOONGSON2_MMC_SEL_DATA);