]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
testUpdateQEMUCaps: Fix memory leak
authorTim Wiederhake <twiederh@redhat.com>
Tue, 20 Apr 2021 11:27:52 +0000 (13:27 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 21 Apr 2021 08:20:48 +0000 (10:20 +0200)
testUpdateQEMUCaps is called multiple times. Use virQEMUCapsUpdateHostCPUModel
instead of virQEMUCapsInitHostCPUModel to not overwrite (and leak) the
pointers in qemuCaps->kvm.hostCPU and qemuCaps->tcg.hostCPU.

Signed-off-by: Tim Wiederhake <twiederh@redhat.com>
Reviewed-by: Michal Privoznik <mprivozn@redhat.com>
tests/qemuxml2argvtest.c

index 572c7b251a30d54d79450bcf8be9d8cd493b7c67..f0efe98d7e350f8a4f3a4ba1b9de2c8c1e90c8e7 100644 (file)
@@ -367,10 +367,10 @@ testUpdateQEMUCaps(const struct testQemuInfo *info,
                          !!(info->flags & FLAG_SKIP_LEGACY_CPUS)) < 0)
         return -1;
 
-    virQEMUCapsInitHostCPUModel(info->qemuCaps, caps->host.arch,
-                                VIR_DOMAIN_VIRT_KVM);
-    virQEMUCapsInitHostCPUModel(info->qemuCaps, caps->host.arch,
-                                VIR_DOMAIN_VIRT_QEMU);
+    virQEMUCapsUpdateHostCPUModel(info->qemuCaps, caps->host.arch,
+                                  VIR_DOMAIN_VIRT_KVM);
+    virQEMUCapsUpdateHostCPUModel(info->qemuCaps, caps->host.arch,
+                                  VIR_DOMAIN_VIRT_QEMU);
 
     return 0;
 }