]> git.ipfire.org Git - thirdparty/bacula.git/commitdiff
Fix error message after connect() in filed and stored
authorEric Bollengier <eric@baculasystems.com>
Fri, 11 Nov 2022 14:49:40 +0000 (15:49 +0100)
committerEric Bollengier <eric@baculasystems.com>
Thu, 14 Sep 2023 11:57:00 +0000 (13:57 +0200)
bacula/src/filed/job.c
bacula/src/stored/dircmd.c

index e487f8a23f79ff5f039a1ade9ee169bb6461c2c5..db3bca625cd3ed1cc90d4099bcf9b68ec9f19006 100644 (file)
@@ -2815,12 +2815,9 @@ static int storage_cmd(JCR *jcr)
       sd->set_source_address(me->FDsrc_addr);
       if (!sd->connect(jcr, 10, (int)me->SDConnectTimeout, me->heartbeat_interval,
                 _("Storage daemon"), jcr->stored_addr, NULL, stored_port, 1)) {
+         Jmsg(jcr, M_FATAL, 0, "%s", sd->errmsg);
          /* destroy() OK because sd is local */
          sd->destroy();
-         Jmsg2(jcr, M_FATAL, 0, _("Failed to connect to Storage daemon: %s:%d\n"),
-             jcr->stored_addr, stored_port);
-         Dmsg2(100, "Failed to connect to Storage daemon: %s:%d\n",
-             jcr->stored_addr, stored_port);
          goto bail_out;
       }
 
index 89c2588981bb50c03debe65c384fc1a08f375f61..5e8680360bae966b7dcc56cf2da32c8bd77f3ae1 100644 (file)
@@ -338,8 +338,6 @@ static bool client_cmd(JCR *jcr)
                 _("Client daemon"), jcr->client_addr, NULL, jcr->client_port, 1)) {
       /* destroy() OK because cl is local */
       Jmsg(jcr, M_FATAL, 0, "%s", cl->errmsg);
-      Dmsg2(100, "Failed to connect to Client daemon: %s:%d\n",
-          jcr->client_addr, jcr->client_port);
       cl->destroy();
       goto bail_out;
    }
@@ -399,12 +397,9 @@ static bool storage_cmd(JCR *jcr)
       /* Try to connect for 1 hour at 10 second intervals */
       if (!sd->connect(jcr, 10, (int)me->ClientConnectTimeout, me->heartbeat_interval,
                 _("Storage daemon"), jcr->stored_addr, NULL, stored_port, 1)) {
+         Jmsg(jcr, M_FATAL, 0, "%s", sd->errmsg);
          /* destroy() OK because sd is local */
          sd->destroy();
-         Jmsg(jcr, M_FATAL, 0, _("[SF0104] Failed to connect to Storage daemon: %s:%d\n"),
-             jcr->stored_addr, stored_port);
-         Dmsg2(010, "Failed to connect to Storage daemon: %s:%d\n",
-             jcr->stored_addr, stored_port);
          goto bail_out;
       }