]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
ch: use g_auto in virCHMonitorBuildCPUJson
authorJán Tomko <jtomko@redhat.com>
Wed, 22 Sep 2021 20:45:51 +0000 (22:45 +0200)
committerJán Tomko <jtomko@redhat.com>
Thu, 23 Sep 2021 13:32:00 +0000 (15:32 +0200)
Signed-off-by: Ján Tomko <jtomko@redhat.com>
Reviewed-by: Laine Stump <laine@redhat.com>
src/ch/ch_monitor.c

index d277466262c982572325544a888091c4681d3a1a..876a553f74223802afcfa45389ecc15f0127f1f6 100644 (file)
@@ -58,7 +58,7 @@ int virCHMonitorPutNoContent(virCHMonitor *mon, const char *endpoint);
 static int
 virCHMonitorBuildCPUJson(virJSONValue *content, virDomainDef *vmdef)
 {
-    virJSONValue *cpus;
+    g_autoptr(virJSONValue) cpus = NULL;
     unsigned int maxvcpus = 0;
     unsigned int nvcpus = 0;
     virDomainVcpuDef *vcpu;
@@ -75,18 +75,14 @@ virCHMonitorBuildCPUJson(virJSONValue *content, virDomainDef *vmdef)
     if (maxvcpus != 0 || nvcpus != 0) {
         cpus = virJSONValueNewObject();
         if (virJSONValueObjectAppendNumberInt(cpus, "boot_vcpus", nvcpus) < 0)
-            goto cleanup;
+            return -1;
         if (virJSONValueObjectAppendNumberInt(cpus, "max_vcpus", vmdef->maxvcpus) < 0)
-            goto cleanup;
+            return -1;
         if (virJSONValueObjectAppend(content, "cpus", &cpus) < 0)
-            goto cleanup;
+            return -1;
     }
 
     return 0;
-
- cleanup:
-    virJSONValueFree(cpus);
-    return -1;
 }
 
 static int