]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
random: vDSO: Remove ifdeffery
authorThomas Weißschuh <thomas.weissschuh@linutronix.de>
Fri, 27 Feb 2026 06:44:41 +0000 (07:44 +0100)
committerBorislav Petkov (AMD) <bp@alien8.de>
Wed, 11 Mar 2026 14:22:49 +0000 (15:22 +0100)
Recent cleanups of the vDSO headers allow the unconditional inclusion of
vdso/datapage.h and the declarations it provides. This also means that
the declaration of vdso_k_rng_data is always visible and its usage does
not need to be guarded by ifdefs anymore. Instead use IS_ENABLED().

Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Signed-off-by: Borislav Petkov (AMD) <bp@alien8.de>
Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
Link: https://patch.msgid.link/20260227-vdso-header-cleanups-v2-15-35d60acf7410@linutronix.de
drivers/char/random.c

index 304cdab939c24e7606b30c5ab27ea4d2c09dd43b..b4da1fb976c11d9455a4ef220a09010673cc44ca 100644 (file)
@@ -56,9 +56,7 @@
 #include <linux/sched/isolation.h>
 #include <crypto/chacha.h>
 #include <crypto/blake2s.h>
-#ifdef CONFIG_VDSO_GETRANDOM
 #include <vdso/datapage.h>
-#endif
 #include <asm/archrandom.h>
 #include <asm/processor.h>
 #include <asm/irq.h>
@@ -267,7 +265,7 @@ static void crng_reseed(struct work_struct *work)
        if (next_gen == ULONG_MAX)
                ++next_gen;
        WRITE_ONCE(base_crng.generation, next_gen);
-#ifdef CONFIG_VDSO_GETRANDOM
+
        /* base_crng.generation's invalid value is ULONG_MAX, while
         * vdso_k_rng_data->generation's invalid value is 0, so add one to the
         * former to arrive at the latter. Use smp_store_release so that this
@@ -281,8 +279,9 @@ static void crng_reseed(struct work_struct *work)
         * because the vDSO side only checks whether the value changed, without
         * actually using or interpreting the value.
         */
-       smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
-#endif
+       if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
+               smp_store_release((unsigned long *)&vdso_k_rng_data->generation, next_gen + 1);
+
        if (!static_branch_likely(&crng_is_ready))
                crng_init = CRNG_READY;
        spin_unlock_irqrestore(&base_crng.lock, flags);
@@ -732,9 +731,8 @@ static void __cold _credit_init_bits(size_t bits)
                if (system_dfl_wq)
                        queue_work(system_dfl_wq, &set_ready);
                atomic_notifier_call_chain(&random_ready_notifier, 0, NULL);
-#ifdef CONFIG_VDSO_GETRANDOM
-               WRITE_ONCE(vdso_k_rng_data->is_ready, true);
-#endif
+               if (IS_ENABLED(CONFIG_VDSO_GETRANDOM))
+                       WRITE_ONCE(vdso_k_rng_data->is_ready, true);
                wake_up_interruptible(&crng_init_wait);
                kill_fasync(&fasync, SIGIO, POLL_IN);
                pr_notice("crng init done\n");