]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
net/mlx5: fs, Fix inverted cap check in tx flow table root disconnect
authorShay Drory <shayd@nvidia.com>
Tue, 27 Jan 2026 08:52:38 +0000 (10:52 +0200)
committerJakub Kicinski <kuba@kernel.org>
Thu, 29 Jan 2026 04:36:05 +0000 (20:36 -0800)
The capability check for reset_root_to_default was inverted, causing
the function to return -EOPNOTSUPP when the capability IS supported,
rather than when it is NOT supported.

Fix the capability check condition.

Fixes: 3c9c34c32bc6 ("net/mlx5: fs, Command to control TX flow table root")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Link: https://patch.msgid.link/1769503961-124173-2-git-send-email-tariqt@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/mellanox/mlx5/core/fs_cmd.c

index ced747bef6415f5bd9a09a7576e18762e7e7aa8a..c348ee62cd3af92c2f3bef5563e51def4de075da 100644 (file)
@@ -1198,7 +1198,8 @@ int mlx5_fs_cmd_set_tx_flow_table_root(struct mlx5_core_dev *dev, u32 ft_id, boo
        u32 out[MLX5_ST_SZ_DW(set_flow_table_root_out)] = {};
        u32 in[MLX5_ST_SZ_DW(set_flow_table_root_in)] = {};
 
-       if (disconnect && MLX5_CAP_FLOWTABLE_NIC_TX(dev, reset_root_to_default))
+       if (disconnect &&
+           !MLX5_CAP_FLOWTABLE_NIC_TX(dev, reset_root_to_default))
                return -EOPNOTSUPP;
 
        MLX5_SET(set_flow_table_root_in, in, opcode,