]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
powerpc/83xx: Add a null pointer check to mcu_gpiochip_add
authorKunwu Chan <chentao@kylinos.cn>
Mon, 15 Jan 2024 09:43:30 +0000 (17:43 +0800)
committerMadhavan Srinivasan <maddy@linux.ibm.com>
Tue, 11 Nov 2025 09:09:25 +0000 (14:39 +0530)
kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure. Ensure the allocation was successful
by checking the pointer validity.

Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
Signed-off-by: Madhavan Srinivasan <maddy@linux.ibm.com>
Link: https://patch.msgid.link/20240115094330.33014-1-chentao@kylinos.cn
arch/powerpc/platforms/83xx/mcu_mpc8349emitx.c

index cb7b9498f291fa4da88f5cf3acb4808f1ed612b4..80d944f2928850b6744c4734b08d94ce65e68448 100644 (file)
@@ -123,6 +123,8 @@ static int mcu_gpiochip_add(struct mcu *mcu)
 
        gc->owner = THIS_MODULE;
        gc->label = kasprintf(GFP_KERNEL, "%pfw", dev_fwnode(dev));
+       if (!gc->label)
+               return -ENOMEM;
        gc->can_sleep = 1;
        gc->ngpio = MCU_NUM_GPIO;
        gc->base = -1;