Fix a possible cause of bug 915 when parsing multiple votes one of which was bad...

svn:r18354

diff --git a/ChangeLog b/ChangeLog
index b9a932aa5072d6579bbeaa8f3f0c5e64ba223c76..c8475746be0bd6efb2318860787f555666040677 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,4 +1,8 @@
 Changes in version 0.2.1.12-alpha - 2009-02-??
+  o Major bugfixes:
+    - Fix an infinite-loop bug on handling corrupt votes under certain
+      circumstances.  Bugfix on 0.2.0.8-alpha.
+
   o Minor bugfixes:
     - Let controllers actually ask for the "clients_seen" event. Bugfix
       on 0.2.1.10-alpha; reported by Matt Edman.

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index b2df638874f1045d39c9e5c1e3486b81a86b5b7f..71f9f9c1939ab13852fc2252dc43839bac093e7f 100644 (file)
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -2167,6 +2167,9 @@ networkstatus_parse_vote_from_string(const char *s, const char **eos_out,
   memarea_t *area = NULL, *rs_area = NULL;
   tor_assert(s);
 
+  if (eos_out)
+    *eos_out = NULL;
+
   if (router_get_networkstatus_v3_hash(s, ns_digest)) {
     log_warn(LD_DIR, "Unable to compute digest of network-status");
     goto err;