Issue #6268: Fix seek() method of codecs.open(), don't read the BOM twice

after seek(0)

diff --git a/Lib/codecs.py b/Lib/codecs.py
index a67240a20fa632ff361b9db84088d1e64be5d84b..e903f2e9148b7f6a2595340216a99e0460d287e3 100644 (file)
--- a/Lib/codecs.py
+++ b/Lib/codecs.py
@@ -694,6 +694,10 @@ class StreamReaderWriter:
         self.reader.reset()
         self.writer.reset()
 
+    def seek(self, offset, whence=0):
+        self.reader.seek(offset, whence)
+        self.writer.seek(offset, whence)
+
     def __getattr__(self, name,
                     getattr=getattr):
 

diff --git a/Lib/test/test_codecs.py b/Lib/test/test_codecs.py
index f8563f61ae65d4a99573384a35ee07a9f24b8ed4..306a3b2ee68bc062886d2c5b619551ecbb2a10ea 100644 (file)
--- a/Lib/test/test_codecs.py
+++ b/Lib/test/test_codecs.py
@@ -1496,6 +1496,26 @@ class WithStmtTest(unittest.TestCase):
             self.assertEquals(srw.read(), u"\xfc")
 
 
+class BomTest(unittest.TestCase):
+    def test_seek0(self):
+        data = "1234567890"
+        tests = ("utf-16",
+                 "utf-16-le",
+                 "utf-16-be",
+                 "utf-32",
+                 "utf-32-le",
+                 "utf-32-be")
+        for encoding in tests:
+            with codecs.open('foo', 'wt+', encoding=encoding) as f:
+                # Check if the BOM is written only once
+                f.write(data)
+                f.write(data)
+                f.seek(0)
+                self.assertEquals(f.read(), data * 2)
+                f.seek(0)
+                self.assertEquals(f.read(), data * 2)
+
+
 def test_main():
     test_support.run_unittest(
         UTF32Test,
@@ -1524,6 +1544,7 @@ def test_main():
         BasicStrTest,
         CharmapTest,
         WithStmtTest,
+        BomTest,
     )
 
 

diff --git a/Misc/NEWS b/Misc/NEWS
index 3656def6cab216092a6ac0de5f8391fcbade27fd..021cac025b5aee0c3fe28bd3dc0dbd2a0ae3c322 100644 (file)
--- a/Misc/NEWS
+++ b/Misc/NEWS
@@ -29,6 +29,9 @@ C-API
 Library
 -------
 
+- Issue #6268: Fix seek() method of codecs.open(), don't read the BOM twice
+  after seek(0)
+
 - Issue #5640: Fix Shift-JIS incremental encoder for error handlers different
   than strict