]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: rsnd: check all BUSIF status when error
authorKuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Thu, 8 Apr 2021 04:28:47 +0000 (13:28 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 May 2021 08:30:06 +0000 (10:30 +0200)
commit a4856e15e58b54977f1c0c0299309ad4d1f13365 upstream.

commit 66c705d07d784 ("SoC: rsnd: add interrupt support for SSI BUSIF
buffer") adds __rsnd_ssi_interrupt() checks for BUSIF status,
but is using "break" at for loop.
This means it is not checking all status. Let's check all BUSIF status.

Fixes: commit 66c705d07d784 ("SoC: rsnd: add interrupt support for SSI BUSIF buffer")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Link: https://lore.kernel.org/r/874kgh1jsw.wl-kuninori.morimoto.gx@renesas.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/soc/sh/rcar/ssi.c

index a2f8138d40c7faf10c48a81b7180f15bd7225ccf..042207c116514de41de6a5a21cadaab2c9be9605 100644 (file)
@@ -797,7 +797,6 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod,
                                                       SSI_SYS_STATUS(i * 2),
                                                       0xf << (id * 4));
                                        stop = true;
-                                       break;
                                }
                        }
                        break;
@@ -815,7 +814,6 @@ static void __rsnd_ssi_interrupt(struct rsnd_mod *mod,
                                                SSI_SYS_STATUS((i * 2) + 1),
                                                0xf << 4);
                                        stop = true;
-                                       break;
                                }
                        }
                        break;