chfn: use direct equality check for semantic clarity and readability

Signed-off-by: Christian Goeschel Ndjomouo <cgoesc2@wgu.edu>

diff --git a/login-utils/chfn.c b/login-utils/chfn.c
index b7cae61761aa8cf5bf881300671ebf72072fcab3..c5435a8bc44d471dd77901084a88d3207b471b8b 100644 (file)
--- a/login-utils/chfn.c
+++ b/login-utils/chfn.c
@@ -248,7 +248,7 @@ static char *ask_new_field(struct chfn_control *ctl, const char *question,
                        free(buf);
                        return xstrdup(def_val);
                }
-               if (!c_strcasecmp(buf, "none")) {
+               if (c_strcasecmp(buf, "none") == 0) {
                        free(buf);
                        ctl->changed = 1;
                        return xstrdup("");
@@ -276,11 +276,11 @@ static void get_login_defs(struct chfn_control *ctl)
                return;
        }
        s = getlogindefs_str("CHFN_RESTRICT", "");
-       if (!strcmp(s, "yes")) {
+       if (strcmp(s, "yes") == 0) {
                ctl->allow_room = ctl->allow_work = ctl->allow_home = 1;
                return;
        }
-       if (!strcmp(s, "no")) {
+       if (strcmp(s, "no") == 0) {
                ctl->allow_fullname = ctl->allow_room = ctl->allow_work = ctl->allow_home = 1;
                return;
        }