]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
soc/tegra: fuse: Fix spurious straps warning on SMCCC platforms
authorBreno Leitao <leitao@debian.org>
Thu, 4 Jun 2026 10:36:17 +0000 (03:36 -0700)
committerThierry Reding <treding@nvidia.com>
Mon, 22 Jun 2026 07:25:36 +0000 (09:25 +0200)
My Grace host started to show this warning:
  WARNING: drivers/soc/tegra/fuse/tegra-apbmisc.c:120 at tegra_read_straps
   tegra30_fuse_add_randomness
   tegra30_fuse_init
   tegra_fuse_probe

tegra_read_straps() warns when the static "chipid" cache is still zero,
using it as a proxy for "APBMISC has been initialised". However chipid
is only ever populated lazily by tegra_read_chipid() when it reads the
APBMISC register.

Guard on apbmisc_base instead, which is set unconditionally in
tegra_init_apbmisc_resources() for all platforms and is already the
sentinel used by tegra_read_chipid().

Fixes: 8b8ee2e56f95 ("soc/tegra: Use ARM SMCCC to get chip ID, revision, and platform info")
Signed-off-by: Breno Leitao <leitao@debian.org>
Signed-off-by: Thierry Reding <treding@nvidia.com>
drivers/soc/tegra/fuse/tegra-apbmisc.c

index 87ae63a7e52d1666df1bb0c656d71131f2261087..7aba7c58bad06672af821b385b06deae1c3a33ca 100644 (file)
@@ -117,7 +117,7 @@ bool tegra_is_silicon(void)
 
 u32 tegra_read_straps(void)
 {
-       WARN(!chipid, "Tegra ABP MISC not yet available\n");
+       WARN(!apbmisc_base, "Tegra ABP MISC not yet available\n");
 
        return strapping;
 }