gpio: cros-ec: use new line value setter callbacks

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. Convert the driver to using
them.

Reviewed-by: Tzung-Bi Shih <tzungbi@kernel.org>
Link: https://lore.kernel.org/r/20250310-gpiochip-set-conversion-v1-11-03798bb833eb@linaro.org
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

diff --git a/drivers/gpio/gpio-cros-ec.c b/drivers/gpio/gpio-cros-ec.c
index 0c09bb54dc0c9e68acd03529621090006b83288c..53cd5ff6247ba7124b0801dac62f9df54fd49c9a 100644 (file)
--- a/drivers/gpio/gpio-cros-ec.c
+++ b/drivers/gpio/gpio-cros-ec.c
@@ -24,24 +24,21 @@
 static const char cros_ec_gpio_prefix[] = "EC:";
 
 /* Setting gpios is only supported when the system is unlocked */
-static void cros_ec_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
+static int cros_ec_gpio_set(struct gpio_chip *gc, unsigned int gpio, int val)
 {
        const char *name = gc->names[gpio] + strlen(cros_ec_gpio_prefix);
        struct cros_ec_device *cros_ec = gpiochip_get_data(gc);
        struct ec_params_gpio_set params = {
                .val = val,
        };
-       int ret;
        ssize_t copied;
 
        copied = strscpy(params.name, name, sizeof(params.name));
        if (copied < 0)
-               return;
+               return copied;
 
-       ret = cros_ec_cmd(cros_ec, 0, EC_CMD_GPIO_SET, &params,
-                         sizeof(params), NULL, 0);
-       if (ret < 0)
-               dev_err(gc->parent, "error setting gpio%d (%s) on EC: %d\n", gpio, name, ret);
+       return cros_ec_cmd(cros_ec, 0, EC_CMD_GPIO_SET, &params,
+                          sizeof(params), NULL, 0);
 }
 
 static int cros_ec_gpio_get(struct gpio_chip *gc, unsigned int gpio)
@@ -191,7 +188,7 @@ static int cros_ec_gpio_probe(struct platform_device *pdev)
        gc->can_sleep = true;
        gc->label = dev_name(dev);
        gc->base = -1;
-       gc->set = cros_ec_gpio_set;
+       gc->set_rv = cros_ec_gpio_set;
        gc->get = cros_ec_gpio_get;
        gc->get_direction = cros_ec_gpio_get_direction;