]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
arm64: dts: qcom: x1e80100-crd: describe HID supplies
authorJohan Hovold <johan+linaro@kernel.org>
Tue, 29 Oct 2024 07:52:58 +0000 (08:52 +0100)
committerBjorn Andersson <andersson@kernel.org>
Tue, 29 Oct 2024 19:53:09 +0000 (14:53 -0500)
Add the missing HID supplies to avoid relying on other consumers to keep
them on.

This also avoids the following warnings on boot:

i2c_hid_of 0-0010: supply vdd not found, using dummy regulator
i2c_hid_of 0-0010: supply vddl not found, using dummy regulator
i2c_hid_of 1-0015: supply vdd not found, using dummy regulator
i2c_hid_of 1-0015: supply vddl not found, using dummy regulator
i2c_hid_of 1-003a: supply vdd not found, using dummy regulator
i2c_hid_of 1-003a: supply vddl not found, using dummy regulator

Note that VREG_MISC_3P3 is also used for things like the fingerprint
reader which are not yet fully described so mark the regulator as always
on for now.

Fixes: d7e03cce0400 ("arm64: dts: qcom: x1e80100-crd: Enable more support")
Reviewed-by: Abel Vesa <abel.vesa@linaro.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241029075258.19642-1-johan+linaro@kernel.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/x1e80100-crd.dts

index f5f2659690915f9ba50d15a27c54e3c0f504a14b..c14c60eafba92e21296da9099e90eec40b63e1ae 100644 (file)
@@ -8,6 +8,7 @@
 #include <dt-bindings/gpio/gpio.h>
 #include <dt-bindings/input/gpio-keys.h>
 #include <dt-bindings/input/input.h>
+#include <dt-bindings/pinctrl/qcom,pmic-gpio.h>
 #include <dt-bindings/regulator/qcom,rpmh-regulator.h>
 
 #include "x1e80100.dtsi"
                regulator-boot-on;
        };
 
+       vreg_misc_3p3: regulator-misc-3p3 {
+               compatible = "regulator-fixed";
+
+               regulator-name = "VREG_MISC_3P3";
+               regulator-min-microvolt = <3300000>;
+               regulator-max-microvolt = <3300000>;
+
+               gpio = <&pm8550ve_8_gpios 6 GPIO_ACTIVE_HIGH>;
+               enable-active-high;
+
+               pinctrl-names = "default";
+               pinctrl-0 = <&misc_3p3_reg_en>;
+
+               regulator-boot-on;
+               regulator-always-on;
+       };
+
        vreg_nvme: regulator-nvme {
                compatible = "regulator-fixed";
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 3 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l12b_1p2>;
+
                pinctrl-0 = <&tpad_default>;
                pinctrl-names = "default";
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 67 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l12b_1p2>;
+
                pinctrl-0 = <&kybd_default>;
                pinctrl-names = "default";
 
                hid-descr-addr = <0x1>;
                interrupts-extended = <&tlmm 51 IRQ_TYPE_LEVEL_LOW>;
 
+               vdd-supply = <&vreg_misc_3p3>;
+               vddl-supply = <&vreg_l15b_1p8>;
+
                pinctrl-0 = <&ts0_default>;
                pinctrl-names = "default";
        };
        status = "okay";
 };
 
+&pm8550ve_8_gpios {
+       misc_3p3_reg_en: misc-3p3-reg-en-state {
+               pins = "gpio6";
+               function = "normal";
+               bias-disable;
+               input-disable;
+               output-enable;
+               drive-push-pull;
+               power-source = <1>; /* 1.8 V */
+               qcom,drive-strength = <PMIC_GPIO_STRENGTH_LOW>;
+       };
+};
+
 &pmc8380_3_gpios {
        edp_bl_en: edp-bl-en-state {
                pins = "gpio4";