- Debug output for #411 and #439: printout internal error and details.

diff --git a/doc/Changelog b/doc/Changelog
index d8f88f88caab4fc358e04f0e3867349b294c477b..3b3073405321c94e7b948bbdca00688358c15783 100644 (file)
--- a/doc/Changelog
+++ b/doc/Changelog
@@ -1,5 +1,6 @@
 5 March 2021: Wouter
        - Workaround for #439: prevent loops in the reuse rbtree.
+       - Debug output for #411 and #439: printout internal error and details.
 
 4 March 2021: Wouter
        - iana portlist update.

diff --git a/services/outside_network.c b/services/outside_network.c
index d2d8c56f5def8604730119071be6416843fe4069..9769b7602d79e13f9ad73a0f3c7bac9c3aa22a02 100644 (file)
--- a/services/outside_network.c
+++ b/services/outside_network.c
@@ -890,7 +890,13 @@ reuse_tcp_remove_tree_list(struct outside_network* outnet,
        verbose(VERB_CLIENT, "reuse_tcp_remove_tree_list");
        if(reuse->node.key) {
                /* delete it from reuse tree */
-               (void)rbtree_delete(&outnet->tcp_reuse, reuse);
+               if(!rbtree_delete(&outnet->tcp_reuse, reuse)) {
+                       /* should not be possible, it should be there */
+                       char buf[256];
+                       addr_to_str(&reuse->addr, reuse->addrlen, buf,
+                               sizeof(buf));
+                       log_err("reuse tcp delete: node not present, internal error, %s ssl %d lru %d", buf, reuse->is_ssl, reuse->item_on_lru_list);
+               }
                reuse->node.key = NULL;
                /* defend against loops on broken tree by zeroing the
                 * rbnode structure */