]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
domain_conf: fix domain deadlock
authorPavel Hrdina <phrdina@redhat.com>
Mon, 22 Sep 2014 16:19:07 +0000 (18:19 +0200)
committerEric Blake <eblake@redhat.com>
Wed, 1 Oct 2014 18:16:51 +0000 (12:16 -0600)
If you use public api virConnectListAllDomains() with second parameter
set to NULL to get only the number of domains you will lock out all
other operations with domains.

Introduced by commit 2c680804.

Signed-off-by: Pavel Hrdina <phrdina@redhat.com>
(cherry picked from commit fc22b2e74890873848b43fffae43025d22053669)

src/conf/domain_conf.c

index 84089ea5287de34a95b2514047c3f8222f3d5911..597939fe0863493f91cb96f973472a1f045b6a9b 100644 (file)
@@ -16547,7 +16547,7 @@ virDomainListPopulate(void *payload,
     /* just count the machines */
     if (!data->domains) {
         data->ndomains++;
-        return;
+        goto cleanup;
     }
 
     if (!(dom = virGetDomain(data->conn, vm->def->name, vm->def->uuid))) {