]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
libcli/auth: return INVALID_PARAMETER for DES in netlogon_creds_{de,en}crypt_samlogon...
authorStefan Metzmacher <metze@samba.org>
Mon, 28 Oct 2024 15:54:48 +0000 (16:54 +0100)
committerJule Anger <janger@samba.org>
Wed, 13 Nov 2024 10:39:12 +0000 (10:39 +0000)
For the NetlogonGenericInformation case we want an error instead of no
encryption if only DES was negotiated...

BUG: https://bugzilla.samba.org/show_bug.cgi?id=15425

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
(cherry picked from commit 131f5c0b251e456c466eaca744525504e1d69492)

libcli/auth/credentials.c

index ec5552e60c07ccabbf4d3b7a2b0d55b9edabdbd1..4fcd1ff96c5b6fa85e97b453626a157aafd54488 100644 (file)
@@ -1114,6 +1114,7 @@ static NTSTATUS netlogon_creds_crypt_samlogon_logon(struct netlogon_creds_Creden
                        }
                } else {
                        /* Using DES to verify kerberos tickets makes no sense */
+                       return NT_STATUS_INVALID_PARAMETER;
                }
                break;
        }