]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
iommufd: Initialize batch->kind in batch_clear()
authorDeepanshu Kartikey <kartikey406@gmail.com>
Sat, 24 Jan 2026 13:22:14 +0000 (18:52 +0530)
committerJason Gunthorpe <jgg@nvidia.com>
Wed, 28 Jan 2026 16:49:17 +0000 (12:49 -0400)
KMSAN reported an uninitialized value when batch_add_pfn_num() reads
batch->kind. This occurs because batch_clear() does not initialize the
kind field.

When batch_add_pfn_num() checks "if (batch->kind != kind)", it reads this
uninitialized value, triggering KMSAN warnings. However the algorithm is
fine with any value in kind at this point as the batch is always empty and
it always corrects kind if wrong.

Initialize batch->kind to zero in batch_clear() to silence the KMSAN
warning.

Link: https://patch.msgid.link/r/20260124132214.624041-1-kartikey406@gmail.com
Reported-by: syzbot+df28076a30d726933015@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=df28076a30d726933015
Fixes: f394576eb11db ("iommufd: PFN handling for iopt_pages")
Tested-by: syzbot+df28076a30d726933015@syzkaller.appspotmail.com
Signed-off-by: Deepanshu Kartikey <kartikey406@gmail.com>
Reviewed-by: Kevin Tian <kevin.tian@intel.com>
Tested-by: syzbot+a0c841e02f328005bbcc@syzkaller.appspotmail.com
Reported-by: syzbot+a0c841e02f328005bbcc@syzkaller.appspotmail.com
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
drivers/iommu/iommufd/pages.c

index dbe51ecb9a20f81efdb4211223c0360a403fee29..f606148920fa72e2586259d4a29c6f0e97508c9e 100644 (file)
@@ -289,6 +289,7 @@ static void batch_clear(struct pfn_batch *batch)
        batch->end = 0;
        batch->pfns[0] = 0;
        batch->npfns[0] = 0;
+       batch->kind = 0;
 }
 
 /*