Always log [bug] warnings from the unit tests.

We should consider them bugs.  If they are happening intentionally,
we should use the log_test_helpers code to capture and suppress
them.  But having them off-by-default has potential to cause
programming errors.

diff --git a/src/test/testing_common.c b/src/test/testing_common.c
index ea9366305cdef06b773407c9365f056a6fe328aa..e3fe87cb4352904fd4a7eb35d42b215f38ee6da1 100644 (file)
--- a/src/test/testing_common.c
+++ b/src/test/testing_common.c
@@ -272,6 +272,8 @@ main(int c, const char **v)
     log_severity_list_t s;
     memset(&s, 0, sizeof(s));
     set_log_severity_config(loglevel, LOG_ERR, &s);
+    /* ALWAYS log bug warnings. */
+    s.masks[LOG_WARN-LOG_ERR] |= LD_BUG;
     add_stream_log(&s, "", fileno(stdout));
   }