]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
ext4: cleanup variable name in ext4_fc_del()
authorDan Carpenter <dan.carpenter@linaro.org>
Fri, 11 Oct 2024 19:43:44 +0000 (22:43 +0300)
committerTheodore Ts'o <tytso@mit.edu>
Wed, 13 Nov 2024 04:54:15 +0000 (23:54 -0500)
The variables "&EXT4_SB(inode->i_sb)->s_fc_lock" and "&sbi->s_fc_lock"
are the same lock.  This function uses a mix of both, which is a bit
unsightly and confuses Smatch.

Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://patch.msgid.link/96008557-8ff4-44cc-b5e3-ce242212f1a3@stanley.mountain
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/fast_commit.c

index 3dee94a38a688ffb3ae22eb53dd9519f94d31fab..26c4fc37edcf9ab8a1d77a27a59c1452a00506a2 100644 (file)
@@ -291,9 +291,9 @@ void ext4_fc_del(struct inode *inode)
                return;
 
 restart:
-       spin_lock(&EXT4_SB(inode->i_sb)->s_fc_lock);
+       spin_lock(&sbi->s_fc_lock);
        if (list_empty(&ei->i_fc_list) && list_empty(&ei->i_fc_dilist)) {
-               spin_unlock(&EXT4_SB(inode->i_sb)->s_fc_lock);
+               spin_unlock(&sbi->s_fc_lock);
                return;
        }