tox: Pin pycares version 4 due to backwards-incompatible changes

diff --git a/docs/caresresolver.rst b/docs/caresresolver.rst
index 4e0058eac09c750202f900c1e489d346be5f4f96..57caa7d19a43c1237330c9ca5fe0f71e25d3df37 100644 (file)
--- a/docs/caresresolver.rst
+++ b/docs/caresresolver.rst
@@ -19,6 +19,9 @@ wrapper ``pycares``).
     the default for ``tornado.simple_httpclient``, but other libraries
     may default to ``AF_UNSPEC``.
 
+    This class requires ``pycares`` version 4. Since this class is deprecated, it will not be
+    updated to support ``pycares`` version 5.
+
     .. deprecated:: 6.2
        This class is deprecated and will be removed in Tornado 7.0. Use the default
        thread-based resolver instead.

diff --git a/tox.ini b/tox.ini
index 88e8eb9dfbd6707881091a5bae922df0b270582d..db0a4b6046763ccd0afd165d070666af3c2cce04 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -46,7 +46,10 @@ basepython =
 deps =
      full: pycurl
      full: twisted
-     full: pycares
+     # Pycares 5 has some backwards-incompatible changes that we don't support.
+     # And since CaresResolver is deprecated, I do not expect to fix it, so just
+     # pin the previous version. (This should really be in requirements.{in,txt} instead)
+     full: pycares<5
      docs: -r{toxinidir}/requirements.txt
      lint: -r{toxinidir}/requirements.txt