]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
soc: microchip: mpfs-control-scb: Fix resource leak on driver unbind
authorFelix Gu <ustc.gu@gmail.com>
Mon, 9 Mar 2026 12:16:14 +0000 (20:16 +0800)
committerConor Dooley <conor.dooley@microchip.com>
Thu, 19 Mar 2026 15:55:16 +0000 (15:55 +0000)
Use devm_mfd_add_devices() instead of mfd_add_devices() to ensure
child devices are properly removed when the driver unbinds.

Fixes: 4aac11c9a6e7 ("soc: microchip: add mfd drivers for two syscon regions on PolarFire SoC")
Signed-off-by: Felix Gu <ustc.gu@gmail.com>
Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
drivers/soc/microchip/mpfs-control-scb.c

index f0b84b1f49cbca7352a7b7fb4a457287d25a3949..8dda5704a389fbc52bbbc801a44f073dcf2dadb9 100644 (file)
@@ -14,8 +14,10 @@ static int mpfs_control_scb_probe(struct platform_device *pdev)
 {
        struct device *dev = &pdev->dev;
 
-       return mfd_add_devices(dev, PLATFORM_DEVID_NONE, mpfs_control_scb_devs,
-                              ARRAY_SIZE(mpfs_control_scb_devs), NULL, 0, NULL);
+       return devm_mfd_add_devices(dev, PLATFORM_DEVID_NONE,
+                                   mpfs_control_scb_devs,
+                                   ARRAY_SIZE(mpfs_control_scb_devs), NULL, 0,
+                                   NULL);
 }
 
 static const struct of_device_id mpfs_control_scb_of_match[] = {