]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
firmware: qcom: scm: preserve assign_mem() error return value
authorMukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Thu, 7 Aug 2025 12:44:51 +0000 (18:14 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Nov 2025 20:34:02 +0000 (15:34 -0500)
[ Upstream commit 121fcf3c871181edce0708a49d2397cedd6ad21f ]

When qcom_scm_assign_mem() fails, the error value is currently being
overwritten after it is logged, resulting in the loss of the original
error code. Fix this by retaining and returning the original error value
as intended.

Signed-off-by: Mukesh Ojha <mukesh.ojha@oss.qualcomm.com>
Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250807124451.2623019-1-mukesh.ojha@oss.qualcomm.com
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/firmware/qcom/qcom_scm.c

index 23aefbf6fca588f257e83fc35c759319ef99efa8..1da16bc79391c52e564977b448e6a534e719fdc2 100644 (file)
@@ -1093,7 +1093,7 @@ int qcom_scm_assign_mem(phys_addr_t mem_addr, size_t mem_sz,
        if (ret) {
                dev_err(__scm->dev,
                        "Assign memory protection call failed %d\n", ret);
-               return -EINVAL;
+               return ret;
        }
 
        *srcvm = next_vm;