Apply suggestions from code review

Co-authored-by: Remi Gacogne <github@coredump.fr>

diff --git a/pdns/recursordist/rec_channel_rec.cc b/pdns/recursordist/rec_channel_rec.cc
index de94371b4ec6731b0f2cc5a623d0d216f9848cc4..3de3fbc6fe867e73ab6c360517267e25401581a3 100644 (file)
--- a/pdns/recursordist/rec_channel_rec.cc
+++ b/pdns/recursordist/rec_channel_rec.cc
@@ -2204,7 +2204,7 @@ static RecursorControlChannel::Answer luaconfig(T begin, T end)
 {
   if (begin != end) {
     if (g_luaSettingsInYAML) {
-      return {1, "Unable to reload Lua script from '" + ::arg()["lua-config-file"] + " as there is not active Lua configuration\n"};
+      return {1, "Unable to reload Lua script from '" + ::arg()["lua-config-file"] + " as there is no active Lua configuration\n"};
     }
     ::arg().set("lua-config-file") = *begin;
   }

diff --git a/pdns/recursordist/settings/cxxsupport.cc b/pdns/recursordist/settings/cxxsupport.cc
index b3c335732f68dfa93f07f7a33cd796f9677bbede..6f206a3d7a42faf8a858e61c1b9019ed8eed083b 100644 (file)
--- a/pdns/recursordist/settings/cxxsupport.cc
+++ b/pdns/recursordist/settings/cxxsupport.cc
@@ -760,7 +760,7 @@ void fromLuaToRust(const FrameStreamExportConfig& fsc, pdns::rust::settings::rec
     dnstap.servers.emplace_back(server);
   }
   dnstap.logQueries = fsc.logQueries;
-  dnstap.logResponses = fsc.logQueries;
+  dnstap.logResponses = fsc.logResponses;
   dnstap.bufferHint = fsc.bufferHint;
   dnstap.flushTimeout = fsc.flushTimeout;
   dnstap.inputQueueSize = fsc.inputQueueSize;
@@ -1295,7 +1295,7 @@ void pdns::settings::rec::fromBridgeStructToLuaConfig(const pdns::rust::settings
   fromRustToLuaConfig(settings.incoming.proxymappings, proxyMapping);
 }
 
-// Return true if an item that's (also) a Lua config ite is set
+// Return true if an item that's (also) a Lua config item is set
 bool pdns::settings::rec::luaItemSet(const pdns::rust::settings::rec::Recursorsettings& settings)
 {
   bool alldefault = true;

diff --git a/pdns/recursordist/settings/docs-new-preamble-in.rst b/pdns/recursordist/settings/docs-new-preamble-in.rst
index 564bc30b01c35a8a5293676760633331944f565f..feb5939f46e2749a615590175feba19cc18ec7c2 100644 (file)
--- a/pdns/recursordist/settings/docs-new-preamble-in.rst
+++ b/pdns/recursordist/settings/docs-new-preamble-in.rst
@@ -390,7 +390,7 @@ As of version 5.1.0, an allowed addtional qtype entry is defined as:
 
 .. code-block:: yaml
 
-   qtype: string represeting a QType
+   qtype: string representing a QType
    targets: [] Sequence of string representing QType
    mode: One of Ignore, CacheOnly, CacheOnlyRequireAuth, ResolveImmediately, ResolveDeferred, default CacheOnlyRequireAuth