]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
net: hns3: remove tx spare info from debugfs.
authorJijie Shao <shaojijie@huawei.com>
Mon, 14 Jul 2025 06:10:28 +0000 (14:10 +0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Jul 2025 23:50:04 +0000 (16:50 -0700)
The tx spare info in debugfs is not very useful,
and there are related statistics available for troubleshooting.

This patch removes the tx spare info from debugfs.

Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Acked-by: Arnd Bergmann <arnd@arndb.de>
Link: https://patch.msgid.link/20250714061037.2616413-2-shaojijie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hns3/hns3_debugfs.c

index 35e57eebcf579b888c45f152ec6ed97dd8b4f98f..aec719ce3ccd9d00dbddbc9174b6a5d28bc7538f 100644 (file)
@@ -570,56 +570,6 @@ static int hns3_dbg_coal_info(struct hnae3_handle *h, char *buf, int len)
        return 0;
 }
 
-static const struct hns3_dbg_item tx_spare_info_items[] = {
-       { "QUEUE_ID", 2 },
-       { "COPYBREAK", 2 },
-       { "LEN", 7 },
-       { "NTU", 4 },
-       { "NTC", 4 },
-       { "LTC", 4 },
-       { "DMA", 17 },
-};
-
-static void hns3_dbg_tx_spare_info(struct hns3_enet_ring *ring, char *buf,
-                                  int len, u32 ring_num, int *pos)
-{
-       char data_str[ARRAY_SIZE(tx_spare_info_items)][HNS3_DBG_DATA_STR_LEN];
-       struct hns3_tx_spare *tx_spare = ring->tx_spare;
-       char *result[ARRAY_SIZE(tx_spare_info_items)];
-       char content[HNS3_DBG_INFO_LEN];
-       u32 i, j;
-
-       if (!tx_spare) {
-               *pos += scnprintf(buf + *pos, len - *pos,
-                                 "tx spare buffer is not enabled\n");
-               return;
-       }
-
-       for (i = 0; i < ARRAY_SIZE(tx_spare_info_items); i++)
-               result[i] = &data_str[i][0];
-
-       *pos += scnprintf(buf + *pos, len - *pos, "tx spare buffer info\n");
-       hns3_dbg_fill_content(content, sizeof(content), tx_spare_info_items,
-                             NULL, ARRAY_SIZE(tx_spare_info_items));
-       *pos += scnprintf(buf + *pos, len - *pos, "%s", content);
-
-       for (i = 0; i < ring_num; i++) {
-               j = 0;
-               sprintf(result[j++], "%u", i);
-               sprintf(result[j++], "%u", ring->tx_copybreak);
-               sprintf(result[j++], "%u", tx_spare->len);
-               sprintf(result[j++], "%u", tx_spare->next_to_use);
-               sprintf(result[j++], "%u", tx_spare->next_to_clean);
-               sprintf(result[j++], "%u", tx_spare->last_to_clean);
-               sprintf(result[j++], "%pad", &tx_spare->dma);
-               hns3_dbg_fill_content(content, sizeof(content),
-                                     tx_spare_info_items,
-                                     (const char **)result,
-                                     ARRAY_SIZE(tx_spare_info_items));
-               *pos += scnprintf(buf + *pos, len - *pos, "%s", content);
-       }
-}
-
 static const struct hns3_dbg_item rx_queue_info_items[] = {
        { "QUEUE_ID", 2 },
        { "BD_NUM", 2 },
@@ -827,8 +777,6 @@ static int hns3_dbg_tx_queue_info(struct hnae3_handle *h,
                pos += scnprintf(buf + pos, len - pos, "%s", content);
        }
 
-       hns3_dbg_tx_spare_info(ring, buf, len, h->kinfo.num_tqps, &pos);
-
        return 0;
 }