]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
samples/damon/prcl: fix boot time enable crash
authorSeongJae Park <sj@kernel.org>
Sun, 6 Jul 2025 19:32:03 +0000 (12:32 -0700)
committerAndrew Morton <akpm@linux-foundation.org>
Sun, 13 Jul 2025 23:38:34 +0000 (16:38 -0700)
If 'enable' parameter of the 'prcl' DAMON sample module is set at boot
time via the kernel command line, memory allocation is tried before the
slab is initialized.  As a result kernel NULL pointer dereference BUG can
happen.  Fix it by checking the initialization status.

Link: https://lkml.kernel.org/r/20250706193207.39810-3-sj@kernel.org
Fixes: 2aca254620a8 ("samples/damon: introduce a skeleton of a smaple DAMON module for proactive reclamation")
Signed-off-by: SeongJae Park <sj@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
samples/damon/prcl.c

index 5597e6a08ab2269751719596b25056b23be6321c..a9d7629d70f0ad850faa28d54d1cdb40556ac8ef 100644 (file)
@@ -109,6 +109,8 @@ static void damon_sample_prcl_stop(void)
                put_pid(target_pidp);
 }
 
+static bool init_called;
+
 static int damon_sample_prcl_enable_store(
                const char *val, const struct kernel_param *kp)
 {
@@ -134,6 +136,14 @@ static int damon_sample_prcl_enable_store(
 
 static int __init damon_sample_prcl_init(void)
 {
+       int err = 0;
+
+       init_called = true;
+       if (enable) {
+               err = damon_sample_prcl_start();
+               if (err)
+                       enable = false;
+       }
        return 0;
 }