]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
drm/i915/wm: Extract skl_print_plane_ddb_changes()
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Thu, 19 Mar 2026 11:40:32 +0000 (13:40 +0200)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Sat, 21 Mar 2026 09:11:51 +0000 (11:11 +0200)
We have skl_print_plane_wm_changes() but the DDB counterpart is
just inline in the main loop. Extract it into a function. We'll
have a second use for this soon.

The "ddb" part is already parametrized in anticipation of the
second user.

v2: Use prink field width for ddb_name alignment

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260319114034.7093-8-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
drivers/gpu/drm/i915/display/skl_watermark.c

index 6c8dab847ae295eabb46ab1ff300ad5f11924d01..6ad0546c928f633b87dc514f14217bcd93dda79b 100644 (file)
@@ -2601,6 +2601,21 @@ static char enast(bool enable)
        return enable ? '*' : ' ';
 }
 
+static void
+skl_print_plane_ddb_changes(struct intel_plane *plane,
+                           const struct skl_ddb_entry *old,
+                           const struct skl_ddb_entry *new,
+                           const char *ddb_name)
+{
+       struct intel_display *display = to_intel_display(plane);
+
+       drm_dbg_kms(display->drm,
+                   "[PLANE:%d:%s] %5s (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",
+                   plane->base.base.id, plane->base.name, ddb_name,
+                   old->start, old->end, new->start, new->end,
+                   skl_ddb_entry_size(old), skl_ddb_entry_size(new));
+}
+
 static noinline_for_stack void
 skl_print_plane_wm_changes(struct intel_plane *plane,
                           const struct skl_plane_wm *old_wm,
@@ -2722,11 +2737,8 @@ skl_print_wm_changes(struct intel_atomic_state *state)
 
                        if (skl_ddb_entry_equal(old, new))
                                continue;
-                       drm_dbg_kms(display->drm,
-                                   "[PLANE:%d:%s] ddb (%4d - %4d) -> (%4d - %4d), size %4d -> %4d\n",
-                                   plane->base.base.id, plane->base.name,
-                                   old->start, old->end, new->start, new->end,
-                                   skl_ddb_entry_size(old), skl_ddb_entry_size(new));
+
+                       skl_print_plane_ddb_changes(plane, old, new, "ddb");
                }
 
                for_each_intel_plane_on_crtc(display->drm, crtc, plane) {