]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
iio: adc: Kconfig: make AD9467 depend on ADI_AXI_ADC symbol
authorAlexandru Ardelean <aardelean@deviqon.com>
Wed, 24 Mar 2021 18:27:46 +0000 (20:27 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 14 May 2021 08:49:44 +0000 (10:49 +0200)
[ Upstream commit 194eafc9c1d49b53b59de9821fb63d423344cae3 ]

Because a dependency on HAS_IOMEM and OF was added for the ADI AXI ADC
driver, this makes the AD9467 driver have some build/dependency issues
when OF is disabled (typically on ACPI archs like x86).

This is because the selection of the AD9467 enforces the ADI_AXI_ADC symbol
which is blocked by the OF (and potentially HAS_IOMEM) being disabled.

To fix this, we make the AD9467 driver depend on the ADI_AXI_ADC symbol.
The AD9467 driver cannot operate on it's own. It requires the ADI AXI ADC
driver to stream data (or some similar IIO interface).

So, the fix here is to make the AD9467 symbol depend on the ADI_AXI_ADC
symbol. At some point this could become it's own subgroup of high-speed
ADCs.

Fixes: be24c65e9fa24 ("iio: adc: adi-axi-adc: add proper Kconfig dependencies")
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Alexandru Ardelean <aardelean@deviqon.com>
Acked-by: Randy Dunlap <rdunlap@infradead.org>
Link: https://lore.kernel.org/r/20210324182746.9337-1-aardelean@deviqon.com
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/iio/adc/Kconfig

index be1f73166a32bbf3fac6cb5a91a069e146614453..6840c1205e6dbbf3e2ecfa36e33c680da7992072 100644 (file)
@@ -249,7 +249,7 @@ config AD799X
 config AD9467
        tristate "Analog Devices AD9467 High Speed ADC driver"
        depends on SPI
-       select ADI_AXI_ADC
+       depends on ADI_AXI_ADC
        help
          Say yes here to build support for Analog Devices:
          * AD9467 16-Bit, 200 MSPS/250 MSPS Analog-to-Digital Converter