vala: Don't process initializer of parameter if error is set

This caused criticals like:

  vala_data_type_compatible: assertion 'self != NULL' failed
  vala_code_node_to_string: assertion 'self != NULL' failed

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 69456f5bd762d5833b6b225d43288d793e0fddb1..98c5e5faff14dbbff40f0ff29bd5a9fcb453a51c 100644 (file)
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -823,6 +823,7 @@ TESTS = \
        semantic/objectcreation-non-public-constructor.test \
        semantic/objectcreation-unsupported-type.test \
        semantic/parameter-accessibility.test \
+       semantic/parameter-default-invalid.test \
        semantic/parameter-default-type.test \
        semantic/parameter-out-default.test \
        semantic/parameter-params.test \

diff --git a/tests/semantic/parameter-default-invalid.test b/tests/semantic/parameter-default-invalid.test
new file mode 100644 (file)
index 0000000..987bc37
--- /dev/null
+++ b/tests/semantic/parameter-default-invalid.test
@@ -0,0 +1,7 @@
+Invalid Code
+
+void foo (int bar = G) {
+}
+
+void main () {
+}

diff --git a/vala/valaparameter.vala b/vala/valaparameter.vala
index e447612d36b712c37e9c73b5d4bfaa165f1609e7..052b06ce83a335aa4a4f88e8fdc80c31abad7378 100644 (file)
--- a/vala/valaparameter.vala
+++ b/vala/valaparameter.vala
@@ -176,7 +176,7 @@ public class Vala.Parameter : Variable {
                        }
                }
 
-               if (initializer != null) {
+               if (initializer != null && !initializer.error) {
                        if (initializer is NullLiteral
                            && !variable_type.nullable
                            && direction != ParameterDirection.OUT) {