]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commitdiff
security_flags.inc, xorg-driver-common.inc: Move SECURITY_X_LDFLAGS logic
authorTom Rini <trini@konsulko.com>
Thu, 1 Feb 2018 14:16:56 +0000 (09:16 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 6 Feb 2018 10:54:33 +0000 (10:54 +0000)
We need to ensure that all xorg modules are linked with
SECURITY_X_LDFLAGS to ensure that they will be able to resolve their run
time dependencies.  The approach of listing each driver in
security_flags.inc lets less frequently used drivers be run-time
broken.  Move the flag logic into xorg-driver-common.inc so that all
xorg modules from all layers will have the correct security flags used.

Cc: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Tom Rini <trini@konsulko.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/conf/distro/include/security_flags.inc
meta/recipes-graphics/xorg-driver/xorg-driver-common.inc

index 7ea1049edff8d41b37f155feb6395c58d49534ea..49d2417a882f634b80108bc8bfc0d918e0c4c6cd 100644 (file)
@@ -59,12 +59,8 @@ TARGET_LDFLAGS_append_class-target = " ${SECURITY_LDFLAGS}"
 SECURITY_LDFLAGS_remove_pn-gcc-runtime = "-fstack-protector-strong"
 SECURITY_LDFLAGS_remove_pn-glibc = "-fstack-protector-strong"
 SECURITY_LDFLAGS_remove_pn-glibc-initial = "-fstack-protector-strong"
-SECURITY_LDFLAGS_pn-xf86-video-fbdev = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-intel = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-omapfb = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-omap = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-vesa = "${SECURITY_X_LDFLAGS}"
-SECURITY_LDFLAGS_pn-xf86-video-vmware = "${SECURITY_X_LDFLAGS}"
+# All xorg module drivers need to be linked this way as well and are
+# handled in recipes-graphics/xorg-driver/xorg-driver-common.inc
 SECURITY_LDFLAGS_pn-xserver-xorg = "${SECURITY_X_LDFLAGS}"
 
 TARGET_CC_ARCH_append_pn-binutils = " ${SELECTED_OPTIMIZATION}"
index fe42f11b68983853b6503cbe0c0f8df33e370449..bca0aade6cb5ac8a8a912bb512d41e894632ec8d 100644 (file)
@@ -38,3 +38,5 @@ def _add_xorg_abi_depends(d, name):
 
     pn = d.getVar("PN")
     d.appendVar('RDEPENDS_' + pn, ' ' + abi)
+
+SECURITY_LDFLAGS = "${SECURITY_X_LDFLAGS}"