]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
regulator: fan53880: Fix vsel_mask setting for FAN53880_BUCK
authorAxel Lin <axel.lin@ingics.com>
Mon, 7 Jun 2021 14:29:07 +0000 (22:29 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 14 Jul 2021 14:59:34 +0000 (16:59 +0200)
[ Upstream commit 2e11737a772b95c6587df73f216eec1762431432 ]

According to the datasheet:
REGISTER DETAILS − 0x02 BUCK, BUCK_OUT is BIT0 ~ BIT7.

So vsel_mask for FAN53880_BUCK should be 0xFF.

Fixes: e6dea51e2d41 ("regulator: fan53880: Add initial support")
Signed-off-by: Axel Lin <axel.lin@ingics.com>
Link: https://lore.kernel.org/r/20210607142907.1599905-1-axel.lin@ingics.com
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/fan53880.c

index 1684faf82ed2598e8bd11f783e9afdbd82104252..94f02f3099dd4cc66e3c2865717a4c62ca4deea0 100644 (file)
@@ -79,7 +79,7 @@ static const struct regulator_desc fan53880_regulators[] = {
                .n_linear_ranges = 2,
                .n_voltages =      0xf8,
                .vsel_reg =        FAN53880_BUCKVOUT,
-               .vsel_mask =       0x7f,
+               .vsel_mask =       0xff,
                .enable_reg =      FAN53880_ENABLE,
                .enable_mask =     0x10,
                .enable_time =     480,