]> git.ipfire.org Git - thirdparty/suricata.git/commitdiff
detect/classtype: fix parsing error checking
authorVictor Julien <victor@inliniac.net>
Tue, 1 Oct 2019 08:19:53 +0000 (10:19 +0200)
committerVictor Julien <victor@inliniac.net>
Tue, 8 Oct 2019 18:31:09 +0000 (20:31 +0200)
src/detect-classtype.c

index bd25882a7367f393652a7b2fde6ecca270cac8d1..b01870ac35f9c578618ea81ceacbf7ad9bcb2d45 100644 (file)
@@ -108,9 +108,9 @@ static int DetectClasstypeSetup(DetectEngineCtx *de_ctx, Signature *s, const cha
     char parsed_ct_name[1024] = "";
     SCClassConfClasstype *ct = NULL;
 
-    if (DetectClasstypeParseRawString(rawstr, parsed_ct_name, sizeof(parsed_ct_name)) < -1) {
-        SCLogError(SC_ERR_PCRE_PARSE, "Error parsing classtype argument supplied with the "
-                   "classtype keyword");
+    if (DetectClasstypeParseRawString(rawstr, parsed_ct_name, sizeof(parsed_ct_name)) < 0) {
+        SCLogError(SC_ERR_PCRE_PARSE, "invalid value for classtype keyword: "
+                "\"%s\"", rawstr);
         goto error;
     }