Merged revisions 180383 via svnmerge from

https://origsvn.digium.com/svn/asterisk/trunk

................
  r180383 | mmichelson | 2009-03-05 13:14:14 -0600 (Thu, 05 Mar 2009) | 31 lines

  Merged revisions 180380 via svnmerge from
  https://origsvn.digium.com/svn/asterisk/branches/1.4

  ........
    r180380 | mmichelson | 2009-03-05 12:58:48 -0600 (Thu, 05 Mar 2009) | 25 lines

    Fix broken mailbox parsing when searchcontexts option is enabled.

    When using the searchcontexts option in voicemail.conf, the code
    made the assumption that all mailbox names defined were unique across
    all contexts. However, the code did nothing to actually enforce this
    assumption, nor did it do anything to alert a user that he may have
    created an ambiguity in his voicemail.conf file by defining the same
    mailbox name in multiple contexts.

    With this change, we now will issue a nice long warning if searchcontexts
    is on and we encounter the same mailbox name in multiple contexts and ignore
    any duplicates after the first box. Whether searchcontexts is enabled or not,
    if we come across a duplicate mailbox in the same context, then we will issue
    a warning and ignore the duplicated mailbox. I have also added a small note
    to voicemail.conf.sample in the explanation for searchcontexts explaining
    that you cannot define the same mailbox in multiple contexts if you have
    enabled the option.

    (closes issue #14599)
    Reported by: lmadsen
    Patches:
          14599.patch uploaded by mmichelson (license 60) (with slight modification)
    Tested by: lmadsen
  ........
................

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.6.1@180425 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/apps/app_voicemail.c b/apps/app_voicemail.c
index fd5f977ff4aaeca4ae1f0c2bb7b00aa2270ea4a4..0bccdc9013b0472dc81c073eea42884439c6d9b4 100644 (file)
--- a/apps/app_voicemail.c
+++ b/apps/app_voicemail.c
@@ -9461,14 +9461,21 @@ static struct ast_vm_user *find_or_create(const char *context, const char *box)
        struct ast_vm_user *vmu;
 
        AST_LIST_TRAVERSE(&users, vmu, list) {
-               if (ast_test_flag((&globalflags), VM_SEARCH) && !strcasecmp(box, vmu->mailbox))
-                       break;
-               if (context && (!strcasecmp(context, vmu->context)) && (!strcasecmp(box, vmu->mailbox)))
-                       break;
+               if (ast_test_flag((&globalflags), VM_SEARCH) && !strcasecmp(box, vmu->mailbox)) {
+                       if (strcasecmp(vmu->context, context)) {
+                               ast_log(LOG_WARNING, "\nIt has been detected that you have defined mailbox '%s' in separate\
+                                               \n\tcontexts and that you have the 'searchcontexts' option on. This type of\
+                                               \n\tconfiguration creates an ambiguity that you likely do not want. Please\
+                                               \n\tamend your voicemail.conf file to avoid this situation.\n", box);
+                       }
+                       ast_log(LOG_WARNING, "Ignoring duplicated mailbox %s\n", box);
+                       return NULL;
+               }
+               if (!strcasecmp(context, vmu->context) && !strcasecmp(box, vmu->mailbox)) {
+                       ast_log(LOG_WARNING, "Ignoring duplicated mailbox %s in context %s\n", box, context);
+                       return NULL;
+               }
        }
-
-       if (vmu)
-               return vmu;
        
        if (!(vmu = ast_calloc(1, sizeof(*vmu))))
                return NULL;

diff --git a/configs/voicemail.conf.sample b/configs/voicemail.conf.sample
index 30100932087519461944fce2821370d3e6d056cb..b9d1dcb127dba3415486a8df524603d39248dd5c 100644 (file)
--- a/configs/voicemail.conf.sample
+++ b/configs/voicemail.conf.sample
@@ -232,6 +232,9 @@ sendvoicemail=yes ; Allow the user to compose and send a voicemail while inside
 ; searchcontexts=yes   ; Current default behavior is to search only the default context
                        ; if one is not specified.  The older behavior was to search all contexts.
                        ; This option restores the old behavior [DEFAULT=no]
+                       ; Note: If you have this option enabled, then you will be required to have
+                       ; unique mailbox names across all contexts. Otherwise, an ambiguity is created
+                       ; since it is impossible to know which mailbox to retrieve when one is requested.
 ; callback=fromvm      ; Context to call back from  
                        ;     if not listed, calling the sender back will not be permitted
 ; exitcontext=fromvm    ; Context to go to on user exit such as * or 0