]> git.ipfire.org Git - thirdparty/libvirt.git/commitdiff
qemu_capabilities: replace code with function call
authorKristina Hanicova <khanicov@redhat.com>
Tue, 2 Aug 2022 15:50:13 +0000 (17:50 +0200)
committerMichal Privoznik <mprivozn@redhat.com>
Wed, 3 Aug 2022 10:53:23 +0000 (12:53 +0200)
Since functions virQEMUCapsFillDomainFeatureSEVCaps() and
virQEMUCapsSEVInfoCopy() essentially do the same thing it does
not make sense to have the code duplicated. This patch replaces
the relevant code in the first function with the function call to
the second one.

Signed-off-by: Kristina Hanicova <khanicov@redhat.com>
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Jonathon Jongsma <jjongsma@redhat.com>
src/qemu/qemu_capabilities.c

index b002fb98ed030e76552f44c930976f5a4d8d5724..c2c55f48006ebce8eb818b5feebbafab67e79cbf 100644 (file)
@@ -6490,23 +6490,7 @@ static void
 virQEMUCapsFillDomainFeatureSEVCaps(virQEMUCaps *qemuCaps,
                                     virDomainCaps *domCaps)
 {
-    virSEVCapability *cap = qemuCaps->sevCapabilities;
-
-    if (!cap)
-        return;
-
-    domCaps->sev = g_new0(virSEVCapability, 1);
-
-    domCaps->sev->pdh = g_strdup(cap->pdh);
-    domCaps->sev->cert_chain = g_strdup(cap->cert_chain);
-    if (cap->cpu0_id != NULL) {
-        domCaps->sev->cpu0_id = g_strdup(cap->cpu0_id);
-    }
-
-    domCaps->sev->cbitpos = cap->cbitpos;
-    domCaps->sev->reduced_phys_bits = cap->reduced_phys_bits;
-    domCaps->sev->max_guests = cap->max_guests;
-    domCaps->sev->max_es_guests = cap->max_es_guests;
+    virQEMUCapsSEVInfoCopy(&domCaps->sev, qemuCaps->sevCapabilities);
 }