Skip fr_assert() for static analysis (CID #1414423)

For static analysis, fr_assert() is plain assert...but otherwise,
for non-debugging versions, it just logs. That means that to
coverity, the mutex won't be unlocked, while in production it
will always be unlocked.

diff --git a/src/lib/server/pool.c b/src/lib/server/pool.c
index 6dd714d57a6b25a0d3e009bc724abf5f2d941ec8..00b5fabd70ece1cefd3807edae976b659dca4d57 100644 (file)
--- a/src/lib/server/pool.c
+++ b/src/lib/server/pool.c
@@ -306,7 +306,13 @@ static fr_pool_connection_t *connection_find(fr_pool_t *pool, void *conn)
                        fr_assert(pthread_equal(this->pthread_id, pthread_id) != 0);
 #endif
 
+#ifndef STATIC_ANALYZER
+                       /*
+                        *      For static analyzers, fr_assert() is assert(),
+                        *      changing semantics so the mutex is not released.
+                        */
                        fr_assert(this->in_use == true);
+#endif
                        return this;
                }
        }