]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/xe: remove unmatched xe_vm_unlock() from __xe_exec_queue_init()
authorMaciej Patelczyk <maciej.patelczyk@intel.com>
Fri, 30 May 2025 13:56:27 +0000 (15:56 +0200)
committerNiranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Mon, 2 Jun 2025 21:04:21 +0000 (14:04 -0700)
There is unmatched xe_vm_unlock() in the __xe_exec_queue_init().
Leftover from commit fbeaad071a98 ("drm/xe: Create LRC BO without VM")

Fixes: fbeaad071a98 ("drm/xe: Create LRC BO without VM")
Signed-off-by: Maciej Patelczyk <maciej.patelczyk@intel.com>
Reviewed-by: Jonathan Cavitt <jonathan.cavitt@intel.com>
Reviewed-by: Matthew Brost <matthew.brost@intel.com>
Signed-off-by: Niranjana Vishwanathapura <niranjana.vishwanathapura@intel.com>
Link: https://lore.kernel.org/r/20250530135627.2821612-1-maciej.patelczyk@intel.com
drivers/gpu/drm/xe/xe_exec_queue.c

index 32c6923df7c370a87f214386576ee6b070ee2e20..fee22358cc09be80f5a86609bc41c589f70e7946 100644 (file)
@@ -114,7 +114,6 @@ static struct xe_exec_queue *__xe_exec_queue_alloc(struct xe_device *xe,
 
 static int __xe_exec_queue_init(struct xe_exec_queue *q)
 {
-       struct xe_vm *vm = q->vm;
        int i, err;
        u32 flags = 0;
 
@@ -136,7 +135,7 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
                q->lrc[i] = xe_lrc_create(q->hwe, q->vm, SZ_16K, q->msix_vec, flags);
                if (IS_ERR(q->lrc[i])) {
                        err = PTR_ERR(q->lrc[i]);
-                       goto err_unlock;
+                       goto err_lrc;
                }
        }
 
@@ -146,9 +145,6 @@ static int __xe_exec_queue_init(struct xe_exec_queue *q)
 
        return 0;
 
-err_unlock:
-       if (vm)
-               xe_vm_unlock(vm);
 err_lrc:
        for (i = i - 1; i >= 0; --i)
                xe_lrc_put(q->lrc[i]);