]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
spi: cadence-qspi: Remove redundant pm_runtime_mark_last_busy call
authorAkif Ejaz <akifejaz40@gmail.com>
Wed, 3 Dec 2025 18:19:21 +0000 (23:19 +0500)
committerMark Brown <broonie@kernel.org>
Sun, 14 Dec 2025 10:39:21 +0000 (19:39 +0900)
The pm_runtime_mark_last_busy() call is redundant in probe function
as pm_runtime_put_autosuspend() already calls pm_runtime_mark_last_busy()
internally to update the last access time of the device before queuing
autosuspend.

Remove the pm_runtime_mark_last_busy() call from the probe function.

Tested on StarFive VisionFive 2 v1.2A board.

Fixes: e1f2e77624db ("spi: cadence-qspi: Fix runtime PM imbalance in probe")
Signed-off-by: Akif Ejaz <akifejaz40@gmail.com>
Link: https://patch.msgid.link/20251203181921.97171-1-akifejaz40@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-cadence-quadspi.c

index af6d050da1c8aceb40383d46551b536e160ae43c..a811004f213422ed3888b67af0963b740e8f2ef7 100644 (file)
@@ -2011,10 +2011,8 @@ static int cqspi_probe(struct platform_device *pdev)
                goto probe_setup_failed;
        }
 
-       if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM))) {
-               pm_runtime_mark_last_busy(dev);
+       if (!(ddata && (ddata->quirks & CQSPI_DISABLE_RUNTIME_PM)))
                pm_runtime_put_autosuspend(dev);
-       }
 
        return 0;
 probe_setup_failed: